Correct the skip-waiting-installed.html behavior #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the latest spec, the skipWaiting promise should be resolved after 'activate' event is dispatched. This change is from w3c/ServiceWorker#1065. Tracing through the spec, skipWaiting() enters "Try Activate". "Try Activate" invokes "Activate". "Activate" blocks until the final step: "13. Run the Update Worker State algorithm passing registration’s active worker and activated as the arguments." "Update Worker State" queues a task to set ServiceWorker#state to 'activated'. But in step 10, we have dispatched the 'activate' event. Therefore the order should be: 1. 'activate' event handler runs 2. skipWaiting() promise resolves 3. ServiceWorker#state is set to 'activated' So we correct the test case here and delete all the wrong expected files. BUG=725616 Change-Id: Id0765988c7cdf48f39bb73ccb3fc0cce6ea60949 Reviewed-on: https://chromium-review.googlesource.com/646244 Commit-Queue: Matt Falkenhagen <[email protected]> Reviewed-by: Matt Falkenhagen <[email protected]> Cr-Commit-Position: refs/heads/master@{#499513}
wpt-pr-bot
approved these changes
Sep 4, 2017
Build PASSEDStarted: 2017-09-04 17:07:30 View more information about this build on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the latest spec, the skipWaiting promise should be resolved
after 'activate' event is dispatched. This change is from
w3c/ServiceWorker#1065.
Tracing through the spec, skipWaiting() enters "Try Activate".
"Try Activate" invokes "Activate". "Activate" blocks until the final step:
"13. Run the Update Worker State algorithm passing registration’s active
worker and activated as the arguments."
"Update Worker State" queues a task to set ServiceWorker#state to 'activated'.
But in step 10, we have dispatched the 'activate' event. Therefore the order
should be:
So we correct the test case here and delete all the wrong expected files.
BUG=725616
Change-Id: Id0765988c7cdf48f39bb73ccb3fc0cce6ea60949
Reviewed-on: https://chromium-review.googlesource.com/646244
Commit-Queue: Matt Falkenhagen [email protected]
Reviewed-by: Matt Falkenhagen [email protected]
Cr-Commit-Position: refs/heads/master@{#499513}